Fix bug with histogram function in parallel #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gayyappan
approved these changes
Oct 29, 2019
cevian
force-pushed
the
fix_histogram_parallel_bug
branch
from
45463a3
to
85dcd34
Compare
Histogram's combine function threw a segfault if both state1 and state2 were NULL. I could only reproduce this case in PG 10. Add a tests that hits this with PG 10.4 Fixes timescale#1490
cevian
force-pushed
the
fix_histogram_parallel_bug
branch
from
85dcd34
to
4c07897
Compare
Codecov Report
@@ Coverage Diff @@
## master #1503 +/- ##
=========================================
Coverage ? 91.81%
=========================================
Files ? 142
Lines ? 20511
Branches ? 0
=========================================
Hits ? 18832
Misses ? 1679
Partials ? 0
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Histogram's combine function threw a segfault if both state1
and state2 were NULL. I could only reproduce this case in
PG 10. Add a tests that hits this with PG 10.4
Fixes #1490